Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port connection pool tests from devdiv #1155

Merged
merged 17 commits into from
Sep 20, 2021
Merged

Port connection pool tests from devdiv #1155

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
474642c
connection pool tests
Jul 7, 2021
41eb983
typo
Jul 7, 2021
8bccaec
separate into individual tests
Jul 8, 2021
dc96f92
Update ConnectionPoolTest.cs
Jul 14, 2021
276eaaf
Update ConnectionPoolTest.cs
Jul 14, 2021
68dcbb6
cleanup
Jul 16, 2021
ffcf084
Revert "cleanup"
Jul 16, 2021
9eda376
cleanup
Jul 16, 2021
f5ca077
Update ConnectionPoolTest.cs
Jul 27, 2021
bd534ad
Apply suggestions from code review
Jul 27, 2021
fff6641
Update src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionP…
Jul 27, 2021
2685c13
Merge branch 'main' into devdivtests
Aug 4, 2021
b0c06d3
Merge branch 'devdivtests' of https://github.com/johnnypham/SqlClient…
Aug 6, 2021
ccb7c69
address feedback
Aug 6, 2021
abf15bf
address feedback
Aug 10, 2021
ef3fba3
style changes
Aug 17, 2021
8cb4f60
trigger ci
Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
trigger ci
  • Loading branch information
Johnny Pham committed Sep 17, 2021
commit 8cb4f605c085df832730ffefa93ae3cdd42e9d2b
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/TransactionPoolTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public static void TransactionCleanupTest(string connectionString)
SqlConnection.ClearAllPools();
ConnectionPoolWrapper connectionPool = null;

using (TransactionScope transScope = new TransactionScope())
using (TransactionScope transScope = new())
{
using SqlConnection connection1 = new(connectionString);
using SqlConnection connection2 = new(connectionString);
Expand Down