Skip to content

SqlConnectionStringBuilder should also be updated to match the default value changes in 4.0.0-preview1 #1248

Closed
@yyjdelete

Description

Describe the bug

4.0.0-preview1 include an broken change update the default value of Encrypt to true in #1210
https://github.com/dotnet/SqlClient/blob/main/release-notes/4.0/4.0.0-preview1.md#encrypt-default-value-set-to-true

But it didn't update SqlConnectionStringBuilder, which lead to confuse when parse an connStr with SqlConnectionStringBuilder(The value from SqlConnectionStringBuilder don't match what's really used by connection)

Expected behavior

  1. new SqlConnectionStringBuilder("").Encrypt should be true(parse from an connStr without Encrypt set)
  2. No idea what new SqlConnectionStringBuilder().Encrypt should be, but at least after fixed case 1, it shouldn't broken roundtrip
    Assert(new SqlConnectionStringBuilder().Encrypt == new SqlConnectionStringBuilder(new SqlConnectionStringBuilder().ToString()).Encrypt)

Further technical details

Microsoft.Data.SqlClient version: 4.0.0-preview1.21237.2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

🐛 Bug!Issues that are bugs in the drivers we maintain.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions