Skip to content

Move all CreateEmitter() tests to Transform(...) #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Move all CreateEmitter() tests to Transform(...) #897

merged 1 commit into from
Apr 19, 2022

Conversation

HurricanKai
Copy link
Member

Thought there would be more. I hope the merge works out.

@HurricanKai HurricanKai requested a review from Perksey as a code owner April 19, 2022 20:15
@HurricanKai HurricanKai enabled auto-merge (squash) April 19, 2022 20:16
Perksey
Perksey approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when CI is fixed.

@HurricanKai HurricanKai merged commit dac966d into develop/3.0 Apr 19, 2022
@HurricanKai HurricanKai deleted the dev/3/createemitter-transform-tests branch April 19, 2022 20:26
@Perksey
Copy link
Member

Perksey commented Apr 19, 2022

oh right develop doesn't need that

@HurricanKai
Copy link
Member Author

CI is broken anyways cause of the broken configuration code in scraper.

@HurricanKai HurricanKai mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HurricanKai @Perksey