hotfix: Inconsistent test failure #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regenerate bindings * Release notes * Apply duct tape
`Enum.ToString()` output is undefined when dealing with aliases, as any alias can be picked. Patched `TestChainLoadWithError` so it will pass regardless of which alias is returned.
|
Can you pull latest main please, the force pushes have made the diff go wonky. Thanks. |
|
Merged |
Perksey
approved these changes
Dec 20, 2021
|
@HurricanKai area owner signoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Enum.ToString()output is undefined when dealing with aliases, as anyalias can be picked. Patched
TestChainLoadWithErrorso it will passregardless of which alias is returned.
Related issues, Discord discussions, or proposals
#706
Further Comments
This is a 'harmless' issue, as the error messages are intended for debugging
purposes. The patch makes the test pass consistently.