Skip to content

SIMD for Silk.NET.Math #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 5, 2021
Merged

SIMD for Silk.NET.Math #665

merged 19 commits into from
Nov 5, 2021

Conversation

WhiteBlackGoose
Copy link
Contributor

@WhiteBlackGoose WhiteBlackGoose commented Nov 2, 2021 •
edited
Loading

Summary of the PR

Starting implementing the SIMD proposal.

Plan for this PR

All methods are for three bitnesses: 64, 128, 256.

  • Create
  • Load
  • Add
  • Subtract
  • Multiply
  • Divide
  • Abs
  • Constants
  • And
  • Or
  • Xor
  • Not
  • AllBitsSet
  • IsHardwareAccelerated

Other:

  • Docs

@WhiteBlackGoose WhiteBlackGoose marked this pull request as ready for review November 3, 2021 12:31
HurricanKai
HurricanKai requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed SSE for now - I think the review comments apply to the other ones as well so not reviewing the rest

Perksey
Perksey reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not codeowner, so these are just general things I noticed in passing: kai can decide whether to care.

@WhiteBlackGoose WhiteBlackGoose mentioned this pull request Nov 3, 2021
Open
Perksey
Perksey reviewed Nov 3, 2021
View reviewed changes
@WhiteBlackGoose
And, Not, Xor, Or
0dbe9d2
@WhiteBlackGoose
AllBitsSet
3dc0325 
Relaxing type constraints for scalar bitwise operations
Perksey
Perksey requested changes Nov 4, 2021
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will put my big X here until #668 is merged.

HurricanKai
HurricanKai requested changes Nov 4, 2021
View reviewed changes
src/Maths/Silk.NET.Maths/Simd/Simd.GetWithElement.cs Outdated
@@ -0,0 +1,91 @@
// Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting this here so I don't forget whether we went through with this change

HurricanKai
HurricanKai approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve and thank you for your huge contribution!
@Perksey please remove your X

@HurricanKai HurricanKai requested a review from Perksey November 5, 2021 17:16
Perksey
Perksey approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eggs benedict

@Perksey Perksey merged commit 554638d into dotnet:feature/math-simd Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

@HurricanKai HurricanKai HurricanKai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhiteBlackGoose @Perksey @HurricanKai