Added ISurface.PreUpdate event #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISurface.PreUpdate event would be used to run things like Input, which need to be updated before the user code's Update is called. In the current state of the library, depending on how the user hooks to the events, it is possible for the input to hook to the IView.Update after the user code, which would result in the user code not seeing the latest input (until the next update).
Perksey
requested changes
Oct 11, 2021
Perksey
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The ISurface.PreUpdate event would be used to run things like Input, which need to be updated before the user code's Update is called.
In the current state of the library, depending on how the user hooks to the events, it is possible for the input to hook to the IView.Update after the user code, which would result in the user code not seeing the latest input (until the next update).
PreUpdate would not ensure things like input are up to date, but Update would.