This is the March 2021 Update (v2.2.0) #418
Conversation
|
Ready for review & merge. |
| pull_request: | ||
| paths: | ||
| - 'src/**/*' | ||
| # don't trust changes to the build system on external PRs |
There was a problem hiding this comment.
? pretty sure this just means on what files it triggers, we could still have changes to the build system and just a single change to src/ is required for it to run too
There was a problem hiding this comment.
Good point, we should investigate this in the future. I don't think external changes actually have any sensitive info such as the token, but you never know...
| } | ||
| } | ||
| } | ||
| using System; |
There was a problem hiding this comment.
No clue what happened in this file, I'm assuming it's fine
There was a problem hiding this comment.
Did this development on Linux, it's probably some terminator mismatch. Benign and we have it in some other places too.
| - Add memory pooling for Input State Capture extensions | ||
| - Add Input State Capture stability and robustness improvements | ||
| - Update to Vulkan 1.2.171 | ||
| - Update to latest OpenGL as of 22nd February 2021 |
| @@ -211,6 +211,8 @@ public static void FreeString(nint ptr, NativeStringEncoding encoding = NativeSt | |||
| } | |||
| } | |||
|
|
|||
| #nullable enable | |||
|
|
||
| /// <summary> | ||
| /// Reads a null-terminated string from unmanaged memory, with the given native encoding. | ||
| /// </summary> | ||
| /// <param name="input">A pointer to memory containing a null-terminated string.</param> | ||
| /// <param name="encoding">The encoding of the string in memory.</param> | ||
| /// <returns>The string read from memory.</returns> | ||
| public static string PtrToString(nint input, NativeStringEncoding encoding = NativeStringEncoding.Ansi) | ||
| public static string? PtrToString(nint input, NativeStringEncoding encoding = NativeStringEncoding.Ansi) |
There was a problem hiding this comment.
One of the unfortunate things with using nint, we can't use [return: NotNullIfNotNull("input")]
| } | ||
| } | ||
|
|
||
| // TODO in 3.0 rent these too! right now the capture extensions are very expensive | ||
| public GamepadState[] Gamepads { get; } |
There was a problem hiding this comment.
another reason all public APIs should just use (RO)Memory
There was a problem hiding this comment.
Yep, that's exactly why this needs to be done in 3.0 because I really want to switch this over to use ROMemory
| @@ -42,25 +42,25 @@ public static class ArbDirectStateAccessOverloads | |||
| thisApi.ClearNamedBufferData(buffer, internalformat, format, type, in data.GetPinnableReference()); | |||
| } | |||
|
|
|||
| public static unsafe void ClearNamedBufferData<T0>(this ArbDirectStateAccess thisApi, [Flow(FlowDirection.In)] uint buffer, [Flow(FlowDirection.In)] InternalFormat internalformat, [Flow(FlowDirection.In)] ARB format, [Flow(FlowDirection.In)] ARB type, [Flow(FlowDirection.In)] ReadOnlySpan<T0> data) where T0 : unmanaged | |||
| public static unsafe void ClearNamedBufferData<T0>(this ArbDirectStateAccess thisApi, [Flow(FlowDirection.In)] uint buffer, [Flow(FlowDirection.In)] SizedInternalFormat internalformat, [Flow(FlowDirection.In)] ARB format, [Flow(FlowDirection.In)] ARB type, [Flow(FlowDirection.In)] ReadOnlySpan<T0> data) where T0 : unmanaged | |||
| namespace Silk.NET.Vulkan.Extensions.KHR | ||
| { | ||
| [Extension("VK_KHR_synchronization2")] | ||
| public unsafe partial class KhrSynchronization2 : NativeExtension<Vk> |
| @@ -83,5 +83,7 @@ public enum AccessFlags : int | |||
| AccessCommandPreprocessReadBitNV = 131072, | |||
| [NativeName("Name", "VK_ACCESS_COMMAND_PREPROCESS_WRITE_BIT_NV")] | |||
| AccessCommandPreprocessWriteBitNV = 262144, | |||
| [NativeName("Name", "VK_ACCESS_NONE_KHR")] | |||
| AccessNoneKhr = 0, | |||
|
@savariya28 Hello? |
Merge pull request #418 from Ultz/hotfix/mar21-fixes
Uh oh!
There was an error while loading. Please reload this page.