Skip to content

Move VMASharp proposed API over to nint #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Move VMASharp proposed API over to nint #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Vulkan/VMASharp_API_For_Review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ namespace VMASharp
public abstract DeviceMemory DeviceMemory { get; }
public abstract long Offset { get; internal set; }
public object? UserData { get; set; }
public abstract IntPtr MappedData { get; }
public abstract nint MappedData { get; }
public void Dispose();
public Result BindBufferMemory(Buffer buffer);
public Result BindBufferMemory(Buffer buffer, long allocationLocalOffset, IntPtr pNext);
public Result BindBufferMemory(Buffer buffer, long allocationLocalOffset, nint pNext);
public Result BindBufferMemory(Buffer buffer, long allocationLocalOffset, void* pNext = null);
public Result BindImageMemory(Image image);
public Result BindImageMemory(Image image, long allocationLocalOffset, IntPtr pNext);
public Result BindImageMemory(Image image, long allocationLocalOffset, nint pNext);
public Result BindImageMemory(Image image, long allocationLocalOffset, void* pNext = null);
public bool TouchAllocation();
public Result Flush(long offset, long size);
public Result Invalidate(long offset, long size);
public abstract IntPtr Map();
public abstract nint Map();
public abstract void Unmap();
public bool TryGetMemory<T>(out Memory<T> memory) where T : unmanaged;
public bool TryGetSpan<T>(out Span<T> span) where T : unmanaged;
Expand Down Expand Up @@ -176,8 +176,8 @@ namespace VMASharp
{
public override DeviceMemory DeviceMemory { get; }
public override long Offset { get; internal set; }
public override IntPtr MappedData { get; }
public override IntPtr Map();
public override nint MappedData { get; }
public override nint Map();
public override void Unmap();
}
public class MapMemoryException : VulkanResultException
Expand Down