Extend Open XML SDK #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning documents in multithreaded scenarios this typically lead to exceptions thrown by the underlying System.IO.Packaging code. This commit, therefore, adds locks to the Save() and Clone() methods to prevent those exceptions from being thrown.
ThomasBarnekow
force-pushed
the
vExtensions
branch
from
a5a207e to
ea6962f
Compare
Add unit tests and related test documents for the "save and clone", "Flat OPC", and "create from template" functionality added to the SDK. Correct assembly name and default namespace settings in project files. Correct namespace names of existing unit tests.
|
@EricWhiteDev Thanks for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EricWhiteDev This is the PR we talked about. It contains:
The "Save and Clone functionality" and "Flat OPC conversion" is what @EricWhiteDev and I discussed quite a while ago. CreateFromTemplate lets you create a document from a template.
Another commit adds an XName property to both OpenXmlElement and OpenXmlAttribute. This supports integration with projects using Linq for XML.
NUnit-based tests can be found here: https://github.com/ThomasBarnekow/Open-XML-SDK-Tests. We should talk about turning them into xUnit tests (because other tests @EricWhiteDev has implemented are also based on xUnit) and including them in a companion test project.
All my tests (not only the unit tests) pass. And those unit tests also cover multithreading scenarios (because I'm using the functionality in multithreaded server-side scenarios).