Ensure GetBuildVersion runs before Clean #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm new to the project, so I validated that my new test failed before my change and passes after, and that this fix addresses the linked issue. However, please let me know if I used an incorrect test pattern. Any feedback or suggestions greatly appreciated. Thanks! |
AArnott
approved these changes
Oct 17, 2024
Collaborator
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
Looks great. Thank you!
This was referenced Aug 1, 2025
This was referenced Aug 15, 2025
This was referenced Sep 3, 2025
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
This was referenced Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067
This change hooks
GetBuildVersioninto theCleantarget. This is important for scenarios where the build version is part of an output's name, such as when using<GeneratePackageOnBuild>. Otherwise, the build version isn't set and the default version (e.g. 1.0.0) is used, resulting in an incomplete clean.