Breaks GeneratePackageOnBuild when targetting multiple frameworks

[xtu-ranplan]

In a VS solution with two projects:

Project	Target Framework	GeneratePackageOnBuild
ClassLibrary1	<TargetFramework>netstandard2.0</TargetFramework>	true
test-GeneratePackageOnBuild	<TargetFrameworks>net8.0;net472</TargetFrameworks>	true

When project ClassLibrary1 has a package reference to NerdBank.GitVersioning, the build fails in Visual Studio with this error:

2>Target _GetProjectReferenceVersions:
2>  Target InvokeGetBuildVersionTask:
2>    Target GetBuildVersionCore:
2>      Building version 1.0 from commit
2>  Target _CheckForUnsupportedTargetFramework:
2>    C:\Program Files\dotnet\sdk\9.0.301\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): error NETSDK1013: The TargetFramework value '' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
2>  Done building target "_CheckForUnsupportedTargetFramework" in project "ClassLibrary1.csproj" -- FAILED.
2>
2>  Done building project "ClassLibrary1.csproj" -- FAILED.
2>
2>Build FAILED.
2>
2>C:\Program Files\dotnet\sdk\9.0.301\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): error NETSDK1013: The TargetFramework value '' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
2>    0 Warning(s)
2>    1 Error(s)
2>

[AArnott]

Interesting. I don't use that property much so I probably just missed it. Thanks for reporting.

I expect there's a project reference from the test-GeneratePackageOnBuild project to the ClassLibrary1 project.

[AArnott]

We should add a regression test in the BuildIntegrationTests.cs file for this. We can use that file's CreateProjectRootElement method to create the second test project, and then add the necessary ProjectReference item and TargetFramework/TargetFrameworks properties in each of the projects.

I'm guessing that the bug is in the MSBuildTargetCaching.targets file, which is where we invoke the MSBuild task.

[AArnott]

It works for me. No error. Can you adjust my repro (or provide your own minimal repro), @xtu-ranplan ?

bug1221repro.zip

[xtu-ranplan]

It works for me. No error. Can you adjust my repro (or provide your own minimal repro), @xtu-ranplan ?

bug1221repro.zip

Thank @AArnott for looking into this. I can reproduce it using your repo. Is it related to the Visual Studio version? Here is the version I am using:

Here is the build log:

Build started at 21:19...
1>------ Build started: Project: ClassLibrary1, Configuration: Debug Any CPU ------
1>Build started 02/07/2025 21:19:52.
1>Target InvokeGetBuildVersionTask:
1>  Target GetBuildVersionCore:
1>    Building version 1.0.1.58008 from commit e298b83fbd8332104a7a25fc3608430267901bcc
1>Target GenerateTargetFrameworkMonikerAttribute:
1>  Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
1>Target CoreGenerateAssemblyInfo:
1>  Skipping target "CoreGenerateAssemblyInfo" because all output files are up-to-date with respect to the input files.
1>Target _GenerateSourceLinkFile:
1>  Source Link is empty, file 'obj\Debug\netstandard2.0\ClassLibrary1.sourcelink.json' does not exist.
1>Target CoreCompile:
1>  CompilerServer: server - server processed compilation - ClassLibrary1 (netstandard2.0)
1>Target CopyFilesToOutputDirectory:
1>  Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\obj\Debug\netstandard2.0\ClassLibrary1.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.dll".
1>  ClassLibrary1 -> C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.dll
1>  Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\obj\Debug\netstandard2.0\ClassLibrary1.pdb" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.pdb".
1>Target _WalkEachTargetPerFramework:
1>Target GenerateNuspec:
1>  The package ClassLibrary1.1.0.1-beta is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
1>  Successfully created package 'C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\ClassLibrary1.1.0.1-beta.nupkg'.
1>
1>Build succeeded.
1>    0 Warning(s)
1>    0 Error(s)
1>
1>Time Elapsed 00:00:06.34
2>------ Build started: Project: test-GeneratePackageOnBuild, Configuration: Debug Any CPU ------
2>Build started 02/07/2025 21:19:59.
2>Target DispatchToInnerBuilds:
2>  Target _GetProjectReferenceTargetFrameworkProperties:
2>  Target ResolveProjectReferences:
2>  Target ResolveAssemblyReferences:
2>  Target InvokeGetBuildVersionTask:
2>    Target GetBuildVersionCore:
2>      Building version 1.0.1.58008 from commit e298b83fbd8332104a7a25fc3608430267901bcc
2>  Target PrepareResources:
2>    Target GenerateTargetFrameworkMonikerAttribute:
2>      Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
2>    Target CoreGenerateAssemblyInfo:
2>      Skipping target "CoreGenerateAssemblyInfo" because all output files are up-to-date with respect to the input files.
2>    Target _GenerateSourceLinkFile:
2>      Source Link is empty, file 'obj\Debug\net8.0\test-GeneratePackageOnBuild.sourcelink.json' does not exist.
2>    Target _GetProjectReferenceTargetFrameworkProperties:
2>    Target ResolveProjectReferences:
2>      CompilerServer: server - server processed compilation - test-GeneratePackageOnBuild (net8.0)
2>    Target _CopyFilesMarkedCopyLocal:
2>      Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net8.0\ClassLibrary1.dll".
2>      Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.pdb" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net8.0\ClassLibrary1.pdb".
2>      Creating "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net8.0\test-Gen.BD5F1637.Up2Date" because "AlwaysCreate" was specified.
2>      Touching "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net8.0\test-Gen.BD5F1637.Up2Date".
2>    Target GetCopyToOutputDirectoryItems:
2>      Target _GetCopyToOutputDirectoryItemsFromTransitiveProjectReferences:
2>    Target CopyFilesToOutputDirectory:
2>      Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net8.0\test-GeneratePackageOnBuild.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net8.0\test-GeneratePackageOnBuild.dll".
2>      Copying reference assembly from "obj\Debug\net8.0\refint\test-GeneratePackageOnBuild.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net8.0\ref\test-GeneratePackageOnBuild.dll".
2>      test-GeneratePackageOnBuild -> C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net8.0\test-GeneratePackageOnBuild.dll
2>      Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net8.0\test-GeneratePackageOnBuild.pdb" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net8.0\test-GeneratePackageOnBuild.pdb".
2>  Target InvokeGetBuildVersionTask:
2>  Target GenerateTargetFrameworkMonikerAttribute:
2>    Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
2>  Target CoreGenerateAssemblyInfo:
2>    Skipping target "CoreGenerateAssemblyInfo" because all output files are up-to-date with respect to the input files.
2>  Target _GenerateSourceLinkFile:
2>    Source Link is empty, file 'obj\Debug\net472\test-GeneratePackageOnBuild.sourcelink.json' does not exist.
2>  Target CoreCompile:
2>    CompilerServer: server - server processed compilation - test-GeneratePackageOnBuild (net472)
2>  Target _CopyFilesMarkedCopyLocal:
2>    Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net472\ClassLibrary1.dll".
2>    Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\ClassLibrary1\bin\Debug\netstandard2.0\ClassLibrary1.pdb" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net472\ClassLibrary1.pdb".
2>    Creating "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net472\test-Gen.BD5F1637.Up2Date" because "AlwaysCreate" was specified.
2>    Touching "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net472\test-Gen.BD5F1637.Up2Date".
2>  Target GetCopyToOutputDirectoryItems:
2>    Target _GetCopyToOutputDirectoryItemsFromTransitiveProjectReferences:
2>  Target CopyFilesToOutputDirectory:
2>    Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net472\test-GeneratePackageOnBuild.dll" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net472\test-GeneratePackageOnBuild.dll".
2>    test-GeneratePackageOnBuild -> C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net472\test-GeneratePackageOnBuild.dll
2>    Copying file from "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\obj\Debug\net472\test-GeneratePackageOnBuild.pdb" to "C:\Users\xiaoming.tu\Downloads\bug1221repro\test-GeneratePackageOnBuild\bin\Debug\net472\test-GeneratePackageOnBuild.pdb".
2>Target _WalkEachTargetPerFramework:
2>  Target _GetTfmSpecificContentForPackage:
2>  Target _GetDebugSymbolsWithTfm:
2>  Target _GetProjectReferenceTargetFrameworkProperties:
2>    Target _GetProjectReferenceTargetFrameworkProperties:
2>    Target ResolveProjectReferences:
2>  Target _GetFrameworksWithSuppressedDependencies:
2>Target InvokeGetBuildVersionTask:
2>Target _GetProjectReferenceVersions:
2>  Target InvokeGetBuildVersionTask:
2>    Target GetBuildVersionCore:
2>      Building version 1.0.1.58008 from commit e298b83fbd8332104a7a25fc3608430267901bcc
2>  Target _CheckForUnsupportedTargetFramework:
2>    C:\Program Files\dotnet\sdk\9.0.301\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): error NETSDK1013: The TargetFramework value '' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
2>  Done building target "_CheckForUnsupportedTargetFramework" in project "ClassLibrary1.csproj" -- FAILED.
2>
2>  Done building project "ClassLibrary1.csproj" -- FAILED.
2>
2>Build FAILED.
2>
2>C:\Program Files\dotnet\sdk\9.0.301\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): error NETSDK1013: The TargetFramework value '' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
2>    0 Warning(s)
2>    1 Error(s)
2>
2>Time Elapsed 00:00:05.61
========== Build: 1 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 21:20 and took 17.088 seconds ==========

[xtu-ranplan]

We should add a regression test in the BuildIntegrationTests.cs file for this. We can use that file's CreateProjectRootElement method to create the second test project, and then add the necessary ProjectReference item and TargetFramework/TargetFrameworks properties in each of the projects.

I'm guessing that the bug is in the MSBuildTargetCaching.targets file, which is where we invoke the MSBuild task.

It's very likely in this file. It deletes TargetFramework property, which fails _CheckForUnsupportedTargetFramework target in Microsoft.NET.TargetFrameworkInference.targets

[Bluubb]

We are experiencing the same issue, which appears to occur only in Visual Studio

Jetbrains Rider IDE: successful build
Visual Studio IDE (Version 17.14.16): fails

Issue seem to exist in Nerdbank.GitVersioning: 3.7.112
till 3.7.77-alpha everything works fine.