Fix links from Breaking changes to What's new #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links which did not use xref were broken (lines 136 and 159). Line 103 worked but I wanted to unify it with the rest. There are two options: 1. use xref - longer path, doesnt require .md suffix 2. use just file name - required .md suffix to work in github I went with option n.2. Not adding the .md suffix would probably work on docs.microsoft.com website but doesn't work when browsing on github.
|
@smitpatel Assigning to you as the 🔗Link Meister 🔗. |
smitpatel
reviewed
Dec 14, 2021
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links which did not use xref were broken (lines 136 and 159). Line 103 worked but I wanted to unify it with the rest. There are two options:
I went with option n.2. Not adding the .md suffix would probably work on docs.microsoft.com website but doesn't work when browsing on github.