Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more breaking changes info for EF Core 6.0 #3512

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Oct 26, 2021

Fixes #3486
Fixes #3488
Fixes #3490

@maumar maumar requested a review from a team October 26, 2021 05:36
@maumar maumar force-pushed the maumar_breaking_changes branch 3 times, most recently from 9768635 to c98fef3 Compare October 26, 2021 06:07
@@ -138,6 +138,33 @@ optionsBuilder.UseInMemoryDatabase("MyDatabase");

This creates/uses a database with the name “MyDatabase”. If `UseInMemoryDatabase` is called again with the same name, then the same in-memory database will be used, allowing it to be shared by multiple context instances.

## In-memory provider 'Include' operation will no longer return results if the included navigation is required but its value is null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## In-memory provider 'Include' operation will no longer return results if the included navigation is required but its value is null
## In-memory provider 'Include' operation no longer returns results if the included navigation is required but its value is null

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally in the EF Core 2.0 upgrade notes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's where the breaking change was introduced (per dotnet/efcore#9470) @ajcvickers thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit... out of date at this point :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I was somewhat surprised myself when I looked at the issue history ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been fighting with my repository tests in EF 6 as well, curious if this is this planned to be addressed or will this be omitted as it has been deemed as expected behavior?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no plans to change this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, appreciate the response! Thank you :)

entity-framework/core/what-is-new/ef-core-2.0/upgrade.md Outdated Show resolved Hide resolved
@maumar maumar merged commit 9f3092e into main Oct 26, 2021
@smitpatel smitpatel deleted the maumar_breaking_changes branch October 26, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants