Document scaffolding of many-to-many as a breaking change #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
reviewed
Oct 25, 2021
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
roji
approved these changes
Oct 25, 2021
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
| @@ -17,6 +17,7 @@ The following API and behavior changes have the potential to break existing appl | |||
| | [Nested optional dependents sharing a table and with no required properties cannot be saved](#nested-optionals) | High | | |||
| | [Changing the owner of an owned entity now throws an exception](#owned-reparenting) | Medium | | |||
| | [Cosmos: Related entity types are discovered as owned](#cosmos-owned) | Medium | | |||
| | [Many-to-many relationships without mapped join entities are now scaffolded](#many-to-many) | Medium | | |||
There was a problem hiding this comment.
Given that this is scaffolding-only, are we sure it warrants being a medium-grade change>?
There was a problem hiding this comment.
I would say yes, if you already have a scaffolded model with a simple many-to-many table
There was a problem hiding this comment.
Your application won't compile and may need significant updates to make it compile. In my mind, it's more of a question between medium and high. But we'll see when the GA feedback starts to come in.
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
ajcvickers
force-pushed
the
PeterboroughScaffoldingLtd1025
branch
from
ff4d966
to
7951e75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3411