Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed formatting and moved to end. #3498

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Fixed formatting and moved to end. #3498

merged 2 commits into from
Oct 22, 2021

Conversation

ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers requested a review from a team October 20, 2021 07:46
This is a library for Pagination on EntityFrameworkCore. Works well with Entity Framework Core as an extension, and supports both asynchronous and synchronous.
It also has many useful features commonly used especially on web development. For EF Core 2, 3, 5.

[Examples and documentation](https://github.com/SitholeWB/Pagination.EntityFrameworkCore.Extensions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excessive number of links?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True; this one is covered by the GitHub link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the nuget package is also documented on GitHub readme

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to link to the NuGet directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to do it for others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there is consistency...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do a follow up PR for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/efteam Any objections to adding NuGet links for extensions?

@ajcvickers
Copy link
Member Author

@ErikEJ Looks like there are no objections, so a PR would be welcome.

@ajcvickers ajcvickers merged commit 9112d48 into main Oct 22, 2021
@ajcvickers ajcvickers deleted the Fixup branch October 22, 2021 07:56
@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 22, 2021

@ajcvickers Should I leave the EF Core 2 only tools and extensions in?

@ajcvickers
Copy link
Member Author

I would leave them in for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants