Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates for breaking changes and switching to daily GA build #3492

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

ajcvickers
Copy link
Member

* Fixes #3489: Document validation of requiredness (nullability) in the in-memory database
* Fixes #3487: Document overriding initialized navigations break
* Fixes #3180: Document enum values breaking change
* Document making value converting nulls internal for 6.0 (dotnet/efcore#26230)
* Move samples to Ga daily build
@ajcvickers ajcvickers requested a review from a team October 17, 2021 19:39
@@ -1743,6 +1743,149 @@ LEFT JOIN [Feet] AS [f] ON [p].[Id] = [f].[Id]
GROUP BY [p].[FirstName]
```

**Example 10:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of examples 🤣 It may be helpful to have a single sentence before each one, summarizing the new capability, otherwise this is a flat list of complicated queries which users may not understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roji That would require me to fully understand each example. :-) It's possible @smitpatel could add such a sentence, or even trim this list. These are basically queries that customers submitted in bugs that did not previously work, and now do. I took the approach of including them because they are literally the kinds of things customers are trying to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. I think it would be useful but it's obviously fine as-is too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update once this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants