-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates for breaking changes and switching to daily GA build #3492
Conversation
ajcvickers
commented
Oct 17, 2021
- Fixes Document validation of requiredness (nullability) in the in-memory database #3489: Document validation of requiredness (nullability) in the in-memory database
- Fixes Document overriding initialized navigations break #3487: Document overriding initialized navigations break
- Fixes Document enum values breaking change #3180: Document enum values breaking change
- Document making value converting nulls internal for 6.0 (Make value converting nulls internal for 6.0 efcore#26230)
- Move samples to Ga daily build
* Fixes #3489: Document validation of requiredness (nullability) in the in-memory database * Fixes #3487: Document overriding initialized navigations break * Fixes #3180: Document enum values breaking change * Document making value converting nulls internal for 6.0 (dotnet/efcore#26230) * Move samples to Ga daily build
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-6.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
@@ -1743,6 +1743,149 @@ LEFT JOIN [Feet] AS [f] ON [p].[Id] = [f].[Id] | |||
GROUP BY [p].[FirstName] | |||
``` | |||
|
|||
**Example 10:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of examples 🤣 It may be helpful to have a single sentence before each one, summarizing the new capability, otherwise this is a flat list of complicated queries which users may not understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roji That would require me to fully understand each example. :-) It's possible @smitpatel could add such a sentence, or even trim this list. These are basically queries that customers submitted in bugs that did not previously work, and now do. I took the approach of including them because they are literally the kinds of things customers are trying to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I think it would be useful but it's obviously fine as-is too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update once this is merged.