Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples code cleanup and verification that all samples run #3022

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Samples code cleanup and verification that all samples run #3022

merged 1 commit into from
Jan 17, 2021

Conversation

ajcvickers
Copy link
Member

Fixes #2935

@ajcvickers ajcvickers requested a review from a team January 17, 2021 20:06
roji
roji approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also bring in the EF Core .editorconfig

samples/core/CompiledQueries/Program.cs Show resolved Hide resolved
@ajcvickers
Copy link
Member Author

ajcvickers commented Jan 17, 2021 •
edited
Loading

Added .editorconfig. (Good catch; this results in fewer changes in indentation.)

@ajcvickers ajcvickers merged commit c3a17d1 into master Jan 17, 2021
@smitpatel smitpatel deleted the MrClean0117 branch January 19, 2021 20:45
@ajcvickers ajcvickers mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that all samples run
2 participants
@ajcvickers @roji