Pr2965v2 #2990
Pr2965v2 #2990
Conversation
2. set Optimise=true (Release build) as Benchmark guidelines 3. append Readkey so results viewable 4. make [some] methods static as analyzer suggestions 5. add .editorconfig file for contributor consistency
explicit SqlClient v2.1.1 my results FYI (YMMV!)
| @@ -0,0 +1,57 @@ | |||
| // * Summary * | |||
There was a problem hiding this comment.
If this file is not used in doc pages then should remove it. It represent one snapshot of benchmark run. User may get confused seeing different data when they run.
There was a problem hiding this comment.
Yeah, also note that there are also some results inline on the page.
| @@ -0,0 +1,57 @@ | |||
| // * Summary * | |||
There was a problem hiding this comment.
Yeah, also note that there are also some results inline on the page.
|
glad we are getting closer, and happy for that .txt file to be removed in the final cut [was just there to contrast the Ratio/etc results as on docco compared with my 1-off experience, and was just there to invite you to re-run "officially" and alter any docco as appropriate. BTW I forgot to flag the Issue #2964 (to be closed when you merge the revised Dickbits). Anyway I am about to upload my next PR to answer my Issue #2991 to keep you guys amused. [please don't ask me to rebase it if/when you merge in the earlier bits]. Enjoy |
| <TargetFramework>net5.0</TargetFramework> | ||
| </PropertyGroup> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
2 space indentation in csproj files please.
There was a problem hiding this comment.
I suppose that an authoritative .editorconfig would have enforced this to give consistent result that we can all celebrate [hooray!]. Anyway, as PR Contributor I always tick the "Collaborators can red-ink and re-hack-at-will" [ok it only nearly says that] so go for pasteurised merge and then we can all move on
There was a problem hiding this comment.
Am also removing the package reference to SqlClient. While it's indeed a good idea to use the latest SqlClient, I'd really rather keep our samples as simple as possible etc.
|
Thanks @DickBaker |
Roji, Hi
Hope this PR2965v2 will be acceptable (I removed editorconfig and Console.Read contentious bits).
NB I explicitly added SqlClient v2.1.1 (18/12/2020) as I recall you recommended it during an EF StandUp (despite not direct dependent in parent EFCoreSqlServer v5.0.1 package). I got some different BM Ratio etc that may relate so I added that to the PR commit [suggest you drop it before merge into master branch].
In response to your encouragement [thanks!] and as noted in earlier comment, I am working up a more complex perf scenario in a separate file some doesn't muddy the stream [or frighten the newts/newbies]. Am looking forward to your/AV/team response as results show some wild Ratios [yup, real-world experience in consulting-land], so I hope you/RoW will enjoy and not take fright and bury it [the censorship we are currently experiencing in UK]. Happy 2021 to the team!