adding documentation for query null semantics #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
null_semantics
branch
2 times, most recently
from
2c9d3e2
to
9238d9d
Compare
maumar
commented
Nov 11, 2020
maumar
commented
Nov 12, 2020
maumar
force-pushed
the
null_semantics
branch
from
9238d9d
to
aed70c4
Compare
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
smitpatel
reviewed
Dec 16, 2020
roji
reviewed
Jan 6, 2021
There was a problem hiding this comment.
This is a really nice addition to our docs.
Once general comment about the samples, is that in some cases the queries don't seem like something users would actually write, and might therefore be confusing:
For example:
var query1 = context.Entities.Where(e => context.ConcatStrings(e.String1, e.String2) != null);It's hard to imagine someone writing this (as opposed to comparing the result of ConcatStrings to some constant).
roji
reviewed
Jan 7, 2021
maumar
force-pushed
the
null_semantics
branch
2 times, most recently
from
4614db5
to
0fc406d
Compare
|
updated |
maumar
force-pushed
the
null_semantics
branch
3 times, most recently
from
42646ab
to
e302e3f
Compare
roji
approved these changes
Jan 8, 2021
entity-framework/core/querying/user-defined-function-mapping.md
Outdated
Show resolved
Hide resolved
entity-framework/core/querying/user-defined-function-mapping.md
Outdated
Show resolved
Hide resolved
|
BTW just noticed there there's both null-comparisons.md and null-semantics.md (duplicate) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1612