Escape strings in annotate attributes
#572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6817,8 +6817,8 @@ private void WithAttributes(NamedDecl namedDecl, bool onlySupportedOSPlatform = | |||
|
|
|||
| case CX_AttrKind_Annotate: | |||
| { | |||
| var annotationText = attr.Spelling; | |||
| outputBuilder.WriteCustomAttribute($"""NativeAnnotation("{annotationText}")"""); | |||
| var annotationText = attr.Spelling.Replace("\"", "\"\"", StringComparison.Ordinal); | |||
There was a problem hiding this comment.
This should rather use the EscapeString(string value) helper which centralizes all the escape string handling and attempts to handle already escaped sequences as well.
tannergooding
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for C++ annotate attributes to contain strings literals, thus they should be correctly escaped before generating the corresponding C# attribute. The easiest way to do this is to use C# verbatim strings, and escape double-quotes (by adding a double-quote).