Cast value if it does not match the ParameterType #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
timcassell
reviewed
Jun 23, 2025
|
|
||
| private ValidationError GetErrorOrDefault(ParameterInstance instance) | ||
| { | ||
| if (!instance.Definition.ParameterType.IsInstanceOfType(instance.Value)) |
There was a problem hiding this comment.
I'm not convinced that this is sufficient to determine assignability. Test with a property of type byte.
There was a problem hiding this comment.
More tests added. All of them are passing the validation check - throwing error if the types are mixed
There was a problem hiding this comment.
That's a bad test. This should succeed.
[Params(0, 1, 5, 9, 10)]
public byte ParamProperty { get; set; }This should fail.
[Params(256, -65536)]
public byte ParamProperty { get; set; }There was a problem hiding this comment.
I'm thinking the logic to get it correct is probably too complicated for our validators, and we should probably just do nothing here and let the compiler error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem if the build fails due to implicit casting of Params
#2708