Skip to content

chore: Update Microsoft.NET.Test.Sdk version#2755

Merged
timcassell merged 2 commits into
dotnet:masterfrom
filzrev:chore-update-testsdk
Jun 7, 2025
Merged

chore: Update Microsoft.NET.Test.Sdk version#2755
timcassell merged 2 commits into
dotnet:masterfrom
filzrev:chore-update-testsdk

Conversation

@filzrev

@filzrev filzrev commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

This PR update Microsoft.NET.Test.Sdk version to latest version to resolve random CI test failure issue (#2753

Other Changes

  • Remove Newtonsoft.Json package dependency to avoid package dependency conflict issue.
  • Add System.Collections.Immutable package.
  • Modify existing WithNuGet benchmarks to use ToImmutableArray instead of NewtonsoftJson.
  • Add SuppressTfmSupportBuildErrors setting
    It's required because Microsoft.NET.Test.Sdk 17.14.1 add validation logics to check TFMs And net461 target failed this validation.
    As far as I've confirmed. It seems safe to ignore this error and tests can execute on net461.

@filzrev filzrev force-pushed the chore-update-testsdk branch from f378bee to 1673015 Compare June 7, 2025 10:02
@AndreyAkinshin

Copy link
Copy Markdown
Member

@timcassell what do you think?

Comment thread samples/BenchmarkDotNet.Samples/IntroNuGet.cs
Comment thread tests/BenchmarkDotNet.IntegrationTests/NugetReferenceTests.cs
@filzrev filzrev force-pushed the chore-update-testsdk branch from 5da5e61 to c534fde Compare June 7, 2025 20:30
@timcassell timcassell merged commit 5c9d070 into dotnet:master Jun 7, 2025
8 checks passed
@AndreyAkinshin AndreyAkinshin added this to the v0.15.1 milestone Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants