Port the .NET (Core) disassembler to ClrMd v2 #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
commented
Jul 18, 2022
| <PackageReference Include="Perfolizer" Version="0.2.1" /> | ||
| <PackageReference Include="System.Management" Version="6.0.0" /> | ||
| <PackageReference Include="System.Reflection.Emit" Version="4.7.0" /> | ||
| <PackageReference Include="System.Reflection.Emit.Lightweight" Version="4.7.0" /> | ||
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.0.0" /> | ||
| <PackageReference Include="Microsoft.Diagnostics.NETCore.Client" Version="0.2.61701" /> |
There was a problem hiding this comment.
we get this dependency from ClrMD now (and it uses newer version)
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've finally managed to port our disassembler to ClrMd v2. It should fix a lot of issues like #2000
I've kept the V1 disassembler for Full .NET Framework, as I was not able to get it working in the way I would be happy about it.
Updating TraceEvent fixes #1756