[Mono] Change AOT mode to Normal AOT with LLVM JIT fall back #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanyang-mono - can you add a comment why we are switching from full to normal aot describing the limitations of these runs in the labs. That way we can discuss with @adamsitnik and Drew to see if we do something about those. |
SamMonoRT
approved these changes
Apr 14, 2022
|
@adamsitnik Please merge this PR when you get a chance. Thanks in advance. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the microbenchmarks use generic type, where Mono full AOT would emit a generic function to handle various types, which is very slow and doesn't worth benchmarking. This is one example:
https://github.com/dotnet/performance/blob/main/src/benchmarks/micro/libraries/System.Numerics.Vectors/Perf_VectorOfT.cs
This PR will change the AOT mode to Normal LLVM AOT with LLVM JIT fallback. Because Normal AOT leaves the generic type cases for JIT to handle. That way optimized code will be emitted.
Additionally, Maui Android is using Profiled AOT with JIT fallback, which is similar to Normal AOT with JIT fallback. Ideally, they would like to leverage LLVM too at some point.
cc: @naricc