[NativeAOT] Set TrimmerDefaultAction to link #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the parts of the dependencies that are used
Comment on lines
+193
to
+204
| { | ||
| StringBuilder sb = new StringBuilder(); | ||
|
|
||
| sb.AppendLine(rootAllApplicationAssemblies ? "<PublishTrimmed>false</PublishTrimmed>" : "<TrimMode>link</TrimMode>"); | ||
|
|
||
| if (!string.IsNullOrEmpty(trimmerDefaultAction)) | ||
| { | ||
| sb.Append($"<TrimmerDefaultAction>{trimmerDefaultAction}</TrimmerDefaultAction>"); | ||
| } | ||
|
|
||
| return sb.ToString(); | ||
| } |
There was a problem hiding this comment.
Nit: these setting got aligned with IL Linker defaults, so it's now:
- PublishTrimmed is implied to be always true when publishing with NativeAOT. At least the framework needs to be trimmed because the experience of not trimming that is just really bad.
- Application assemblies are rooted by default. One can opt them into trimming with
<TrimmerDefaultAction>link</TrimmerDefaultAction>
So one could actually fold this into the existing bool rootAllApplicationAssemblies: if it's true, do nothing. If it's false, add <TrimmerDefaultAction>link</TrimmerDefaultAction>.
There was a problem hiding this comment.
It's almost hidden, but <TrimmerDefaultAction>link</TrimmerDefaultAction> is our default now.
There was a problem hiding this comment.
I've sent #1975 to address it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that trimmer only analyzes the parts of the dependencies that are used. With this setting, the build time for our samples project goes from 116 to 15 seconds! I've tested it with dotnet/performance microbenchmarks and everything works fine. In case it does not, users can still disable it:
cc @MichalStrehovsky