-
-
Notifications
You must be signed in to change notification settings - Fork 990
Improve support for NativeAOT #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b9d8130
remove Obsolete fields
adamsitnik a2abf54
add a possibility to disable specific benchmarks for AOT runtimes
adamsitnik 2577df8
remove support for old experimental builds of CoreRT that are targett…
adamsitnik 75d9c6a
introduce NativeAotRuntime
adamsitnik c2c3513
rename --coreRtVersion to --ilCompilerVersion (not dependent on CoreR…
adamsitnik 4b344aa
update default ILCompilerVersion and NuGet feed url to point to lates…
adamsitnik 685ac9f
IsCoreRT should return false on .NET 7
adamsitnik 8fdf0fe
get rid of the warning
adamsitnik a0c1551
annotate GenericTypeArgumentsAttribute with [DynamicallyAccessedMembe…
adamsitnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
src/BenchmarkDotNet.Annotations/Attributes/DynamicallyAccessedMemberTypes.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Diagnostics.CodeAnalysis | ||
{ | ||
/// <summary> | ||
/// Specifies the types of members that are dynamically accessed. | ||
/// | ||
/// This enumeration has a <see cref="FlagsAttribute"/> attribute that allows a | ||
/// bitwise combination of its member values. | ||
/// </summary> | ||
[Flags] | ||
internal enum DynamicallyAccessedMemberTypes | ||
{ | ||
/// <summary> | ||
/// Specifies no members. | ||
/// </summary> | ||
None = 0, | ||
|
||
/// <summary> | ||
/// Specifies the default, parameterless public constructor. | ||
/// </summary> | ||
PublicParameterlessConstructor = 0x0001, | ||
|
||
/// <summary> | ||
/// Specifies all public constructors. | ||
/// </summary> | ||
PublicConstructors = 0x0002 | PublicParameterlessConstructor, | ||
|
||
/// <summary> | ||
/// Specifies all non-public constructors. | ||
/// </summary> | ||
NonPublicConstructors = 0x0004, | ||
|
||
/// <summary> | ||
/// Specifies all public methods. | ||
/// </summary> | ||
PublicMethods = 0x0008, | ||
|
||
/// <summary> | ||
/// Specifies all non-public methods. | ||
/// </summary> | ||
NonPublicMethods = 0x0010, | ||
|
||
/// <summary> | ||
/// Specifies all public fields. | ||
/// </summary> | ||
PublicFields = 0x0020, | ||
|
||
/// <summary> | ||
/// Specifies all non-public fields. | ||
/// </summary> | ||
NonPublicFields = 0x0040, | ||
|
||
/// <summary> | ||
/// Specifies all public nested types. | ||
/// </summary> | ||
PublicNestedTypes = 0x0080, | ||
|
||
/// <summary> | ||
/// Specifies all non-public nested types. | ||
/// </summary> | ||
NonPublicNestedTypes = 0x0100, | ||
|
||
/// <summary> | ||
/// Specifies all public properties. | ||
/// </summary> | ||
PublicProperties = 0x0200, | ||
|
||
/// <summary> | ||
/// Specifies all non-public properties. | ||
/// </summary> | ||
NonPublicProperties = 0x0400, | ||
|
||
/// <summary> | ||
/// Specifies all public events. | ||
/// </summary> | ||
PublicEvents = 0x0800, | ||
|
||
/// <summary> | ||
/// Specifies all non-public events. | ||
/// </summary> | ||
NonPublicEvents = 0x1000, | ||
|
||
/// <summary> | ||
/// Specifies all members. | ||
/// </summary> | ||
All = ~None | ||
} | ||
} |
46 changes: 46 additions & 0 deletions
46
src/BenchmarkDotNet.Annotations/Attributes/DynamicallyAccessedMembersAttribute.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Diagnostics.CodeAnalysis | ||
{ | ||
/// <summary> | ||
/// Indicates that certain members on a specified <see cref="Type"/> are accessed dynamically, | ||
/// for example through <see cref="System.Reflection"/>. | ||
/// </summary> | ||
/// <remarks> | ||
/// This allows tools to understand which members are being accessed during the execution | ||
/// of a program. | ||
/// | ||
/// This attribute is valid on members whose type is <see cref="Type"/> or <see cref="string"/>. | ||
/// | ||
/// When this attribute is applied to a location of type <see cref="string"/>, the assumption is | ||
/// that the string represents a fully qualified type name. | ||
/// | ||
/// If the attribute is applied to a method it's treated as a special case and it implies | ||
/// the attribute should be applied to the "this" parameter of the method. As such the attribute | ||
/// should only be used on instance methods of types assignable to System.Type (or string, but no methods | ||
/// will use it there). | ||
/// </remarks> | ||
[AttributeUsage( | ||
AttributeTargets.Field | AttributeTargets.ReturnValue | AttributeTargets.GenericParameter | | ||
AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.Method, | ||
Inherited = false)] | ||
internal sealed class DynamicallyAccessedMembersAttribute : Attribute | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="DynamicallyAccessedMembersAttribute"/> class | ||
/// with the specified member types. | ||
/// </summary> | ||
/// <param name="memberTypes">The types of members dynamically accessed.</param> | ||
public DynamicallyAccessedMembersAttribute(DynamicallyAccessedMemberTypes memberTypes) | ||
{ | ||
MemberTypes = memberTypes; | ||
} | ||
|
||
/// <summary> | ||
/// Gets the <see cref="DynamicallyAccessedMemberTypes"/> which specifies the type | ||
/// of members dynamically accessed. | ||
/// </summary> | ||
public DynamicallyAccessedMemberTypes MemberTypes { get; } | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/BenchmarkDotNet/Attributes/Filters/AotFilterAttribute.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
using BenchmarkDotNet.Filters; | ||
|
||
namespace BenchmarkDotNet.Attributes.Filters | ||
{ | ||
public class AotFilterAttribute : FilterConfigBaseAttribute | ||
{ | ||
public AotFilterAttribute(string reason = null) | ||
: base(new SimpleFilter(benchmark => !benchmark.GetRuntime().IsAOT)) | ||
{ | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately placing the DAMAttribute on an array is a no-op. Arrays are difficult to model in a static analysis.
This should be generating a warning along the lines of
Trim analysis warning IL2098: GenericTypeArgumentsAttribute..ctor(Type[]): Parameter '#1' of method 'GenericTypeArgumentsAttribute..ctor(Type[])' has 'DynamicallyAccessedMembersAttribute', but that attribute can only be applied to parameters of type 'System.Type' or 'System.String'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this actually broke building
dotnet/performance
withdotnet/runtime
. When building a wasm project, I get - https://gist.github.com/radical/b75b5e4063d97be0adac729b611990ea . Can we revert this change? @adamsitnikThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remove that attribute from the param, then it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, this breaks when I update
bdn
reference indotnet/performance
to0.13.1.1740
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute is a no-op - it should be removed because even in the absence of the illink bug, it generates a warning. NativeAOT doesn't have the linker bug and that's why it works there. I filed https://github.com/dotnet/linker/issues/2714 on the linker bug - that one should also be fixed independently of this removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent #1973 to address that. @radical is there any chance you could test it to see if it actually helps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can build with that change 👍