Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for enabling VeryLargeObjects setting #1524

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow for enabling VeryLargeObjects setting #1524

wants to merge 4 commits into from

Conversation

adamsitnik
Copy link
Member

Fixes #1519

We were not supporting VeryLargeObjects because:

  • it was not possible in .NET Core 1.0 when project.json was a thing. Now it's enabled by default and I have simply removed this artificial limitation
  • in full .NET Framework project when using CsProjClassicNetToolchain because the Generator was generating the correct .config file but afterward when Builder was calling dotnet build and it was overwriting this file and removing the custom settings ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
Area:Toolchains
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling AllowVeryLargeObjects has no effect on Framework benchmark process with Core host process
2 participants
@adamsitnik @AndreyAkinshin