Skip to content

Improve error logging to diagnose unstable tests #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2019

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Jan 9, 2019

Some of our tests are still unstable which can be very confusing for new contributors (#1006).

In this PR I am going to improve the error logging, reproduce the faiulres and fix them.

/cc @CodeTherapist

@adamsitnik
Copy link
Member Author

I am going to close and reopen it to trigger CI once again

@adamsitnik adamsitnik closed this Jan 9, 2019
@adamsitnik adamsitnik reopened this Jan 9, 2019
@adamsitnik adamsitnik closed this Jan 10, 2019
@adamsitnik adamsitnik reopened this Jan 10, 2019
@adamsitnik
Copy link
Member Author

adamsitnik commented Jan 10, 2019

three times in a row all CIs are green. Looks like our problems are gone.

@adamsitnik adamsitnik merged commit fd0b8c0 into master Jan 10, 2019
@adamsitnik adamsitnik added this to the v0.11.4 milestone Jan 10, 2019
@adamsitnik adamsitnik deleted the unstableTestExperiment branch January 10, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant