-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override InputNumber type attribute #33557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the new example - it's more fun than the one I drafted up 🙂
However, I'm wondering if we should keep the docs for this feature a bit shorter. Overriding the type
attribute on InputNumber
is a pretty niche scenario that can likely be mentioned in passing rather than getting a section dedicated to it. Do you agree? I appreciate that it's a cool example, I'm just worried that it could make the docs a bit noisy when we're mostly trying to highlight the line(s) with <InputNumber type="range" />
.
e.g., we could even just have a note somewhere like: Note The |
I suppose so. We don't have a dedicated section for I'll see about knocking it down to something simple in the main coverage, and then I'll place a reduced full example component in the What's New coverage ... Star Trek, of course! 😆 |
Nevermind ... I had time now to adjust it before leaving. Try it now. |
Ok ... I'm done mess'in around with it. 😆 |
@MackinnonBuck ... See if that (finally 🙈) gets it. I have 🍺 in the fridge. Maybe I need to drink one ............ or FIVE! 😆 |
Looks great! |
Fixes #33556
Mackinnon ...
Internal previews