-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 Update: SignalR Config: stateful reconnect (try 2) #30850
Conversation
Also updated per @BrennanConroy request (in previous closed version of this PR) to move the server example to the top example. |
@BrennanConroy, I closed the earlier PR for this and started over with this clean one to get through a merge conflict and a messed up branch. Your requested change to move the server hub endpoint example up is in. I also cleaned up some repeated statements to make it a little more concise. Does this look good? |
Co-authored-by: Brennan <brecon@microsoft.com>
…ub.com/dotnet/AspNetCore.Docs into wadepickett/30674SignalConfigStateful2
Hopefully, this all looks good. Thanks again for your help! Internal review: version 8, stateful reconnect section of SignalR Config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, feel free to not take the suggestions other than the typo fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already link to the Configuration article -- you could omit the duplication of configuration details here, just announce the availability of SR and explain what it is, then rely on the link to the Configuration doc for the details about how to enable it. Just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A good point. I considered not calling out the configuration options themselves and linking instead, but looking over the whole What's new doc, we tend to provide an example of the API or property that is new or changed. So I decided to keep with what that topic was already doing.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Internal review: version 8, stateful reconnect section of SignalR Config
Internal review: What's New: SignalR: Stateful reconnect
Fixes #30674
Added new section: Configure stateful reconnect
(I had to close an earlier PR of this #30829 and start over since I introduced some merge conflicts that were a bit too messy.)
Internal previews