Skip to content

Warn about routing with special chars /6 #28213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Jan 27, 2023

Fixes #27900

Internal review URL

Public review of the doc build:

  • download the HTML files
  • unzip
  • view HTML file in a browser.
  • For links outside the doc, remove the review. from URL.

@Rick-Anderson Rick-Anderson marked this pull request as ready for review January 27, 2023 01:04
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Jan 27, 2023

@SchroterQuentin @ArthurHNL @DanielBryars @skovalyova @talshloman @celluj34 @thegrahamking please review and suggest better wording. I'm hoping to make this very visible so folks can find it before spending a lot of time debugging. Hopefully those who hit this problem will click on the GitHub issue and provide feedback so we can get a good idea how common this problem is.

@thegrahamking
Copy link

I've only observed the behaviour with /, so can only comment that that is correct. I suggest adding wording regarding workarounds e.g. use query string params

| ----| ---------- |
| `/` | `%2F` |
| `+` | `%2B` |
| ` ` | `+` |
Copy link
Member

@Tratcher Tratcher Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ -> is form encoding, not url encoding, it shouldn't affect the path.

@Rick-Anderson Rick-Anderson merged commit 2fecfdd into main Feb 1, 2023
@Rick-Anderson Rick-Anderson deleted the routingWithSlash branch February 1, 2023 22:14
@ArthurHNL
Copy link

@Rick-Anderson Sorry for my late reply, I got quite sick over the weekend. But this change looks good. Thanks for clearing this up in the documentation.

1 similar comment
@ArthurHNL
Copy link

@Rick-Anderson Sorry for my late reply, I got quite sick over the weekend. But this change looks good. Thanks for clearing this up in the documentation.

@Mosch0512
Copy link

i feel like : should also be documentet here?

Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
* Warn about routing with special chars /6

* Update aspnetcore/includes/routeSlash.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about routing with special characters not working in .net core, 5+
5 participants