Add docs for MessagePack #21090
Add docs for MessagePack #21090
Conversation
| @@ -172,6 +192,30 @@ InvalidDataException: Error binding arguments. Make sure that the types of the p | |||
|
|
|||
| For more information on this limitation, see GitHub issue [aspnet/SignalR#2937](https://github.com/aspnet/SignalR/issues/2937). | |||
|
|
|||
| ### Passing Class information in Java | |||
There was a problem hiding this comment.
This isn't specific to MessagePack is it?
There was a problem hiding this comment.
No, but it's only required in MessagePack, JSON still works without it. I could move this to java-client.md and call out the differences there.
There was a problem hiding this comment.
How does JSON manage to work without it given the type erasure? It's also probably worth pointing out type erasure is the reason a TypeReference is necessary.
There was a problem hiding this comment.
Oh, you're right, I was remembering wrong - JSON had the same issue with more complex types but we hadn't noticed before. I'll move this segment & expand it now.
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Stephen Halter <halter73@gmail.com>
|
Once https://docs.microsoft.com/en-us/java/api/com.microsoft.signalr?view=aspnet-signalr-java is updated for 5.0, we should link to the TypeReference docs from here. |
|
@BrennanConroy @Rick-Anderson What do we have to do to update the SignalR Java client API docs for 5.0? |
Co-authored-by: Stephen Halter <halter73@gmail.com>
|
* Add docs for MessagePack * Triple up * Update messagepackhubprotocol.md * Update aspnetcore/signalr/messagepackhubprotocol.md Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> * Update aspnetcore/signalr/messagepackhubprotocol.md Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> * Update aspnetcore/signalr/messagepackhubprotocol.md Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> * Update aspnetcore/signalr/messagepackhubprotocol.md Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> * Update aspnetcore/signalr/messagepackhubprotocol.md Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> * Feedback 1 * More feedback * Move TypeReference info to Java-client.md * Update aspnetcore/signalr/java-client.md Co-authored-by: Stephen Halter <halter73@gmail.com> * Feedback * Update aspnetcore/signalr/java-client.md Co-authored-by: Stephen Halter <halter73@gmail.com> Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> Co-authored-by: Stephen Halter <halter73@gmail.com>
Internal Review
Resolves dotnet/aspnetcore#26248