-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.rst #1777
Update index.rst #1777
Conversation
Improved the description of the AddEnvironmentVariables prefix parameter. The prefix is being removed from the environment variable names and it was not mentioned anywhere. You had to guess...
Hi @miguelcrpinto, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
@divega does this need clarification? |
@Rick-Anderson I think the change looks good (although it is missing a period at the end). The prefix is used as a filter (which was already captured in the first sentence) but it is also removed from the environment variable names to create the configuration keys. |
@danroth27 @spboyer how do we want to handle this? |
Since this is a /// comment should the PR go against the aspnet code here: |
I felt that this needed some clarification because the parameteless overload of the method just loads all environment variables and doesn't modify their name. I do agree with the suggestion from @spboyer , this behavior should be mentioned both in the documentation (with something like what I proposed) and in the /// comments. I spent almost 2 hours trying to figure out what was going wrong with my environment variables until I decided to dive into the method source. |
Done: aspnet/Configuration#488 |
Improved the description of the AddEnvironmentVariables prefix parameter.
The prefix is being removed from the environment variable names and it was not mentioned anywhere. You had to guess...