Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #1777

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Update index.rst #1777

merged 1 commit into from
Aug 16, 2016

Conversation

miguelcrpinto
Copy link
Contributor

Improved the description of the AddEnvironmentVariables prefix parameter.

The prefix is being removed from the environment variable names and it was not mentioned anywhere. You had to guess...

Improved the description of the AddEnvironmentVariables prefix parameter.

The prefix is being removed from the environment variable names and it was not mentioned anywhere. You had to guess...
@dnfclas
Copy link

dnfclas commented Aug 12, 2016

Hi @miguelcrpinto, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Rick-Anderson
Copy link
Contributor

@divega does this need clarification?

@divega
Copy link
Contributor

divega commented Aug 12, 2016

@Rick-Anderson I think the change looks good (although it is missing a period at the end). The prefix is used as a filter (which was already captured in the first sentence) but it is also removed from the environment variable names to create the configuration keys.

@Rick-Anderson
Copy link
Contributor

@danroth27 @spboyer how do we want to handle this?

@spboyer
Copy link
Contributor

spboyer commented Aug 14, 2016

@miguelcrpinto
Copy link
Contributor Author

I felt that this needed some clarification because the parameteless overload of the method just loads all environment variables and doesn't modify their name.

I do agree with the suggestion from @spboyer , this behavior should be mentioned both in the documentation (with something like what I proposed) and in the /// comments.

I spent almost 2 hours trying to figure out what was going wrong with my environment variables until I decided to dive into the method source.

@miguelcrpinto
Copy link
Contributor Author

Done: aspnet/Configuration#488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants