Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Application Insights related warnings in dotnet build. #33

Closed
wants to merge 3 commits into from
Closed

Conversation

goh-chunlin
Copy link
Member

This PR is to fix the following two warnings.

warning CS0618: 'TelemetryConfiguration.Active' is obsolete: 'We do not recommend using TelemetryConfiguration.Active on .NET Core. See microsoft/ApplicationInsights-dotnet#1152 for more details'

warning CS0618: 'ApplicationInsightsLoggerFactoryExtensions.AddApplicationInsights(ILoggerFactory, IServiceProvider, LogLevel)' is obsolete: 'ApplicationInsightsLoggerProvider is now enabled by default when enabling ApplicationInsights monitoring using UseApplicationInsights extension method on IWebHostBuilder or AddApplicationInsightsTelemetry extension method on IServiceCollection. From 2.7.0-beta3 onwards, calling this method will result in double logging and filters applied will not get applied. If interested in using just logging provider, then please use Microsoft.Extensions.Logging.ApplicationInsightsLoggingBuilderExtensions.AddApplicationInsights from Microsoft.Extensions.Logging.ApplicationInsights package. Read more https://aka.ms/ApplicationInsightsILoggerFaq'

@clairernovotny
Copy link
Member

Can you please merge/rebase on top of the master to have a clean build?

@goh-chunlin
Copy link
Member Author

Hi @onovotny, I have merged the new changes. Please review.

Thank you. =)

@clairernovotny
Copy link
Member

Thanks for this. It was done a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants