This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Admin page #324
Merged
Admin page #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- will also only display menu option if user is logged in as an admin
- also a little bit of cleanup
|
Addition to the menu dropdown What the "main" Admin screen looks like. Essentially the catalog page but with "Edit" buttons for each. Edit Screen. You're able to edit Name and Price. Showing that updates made on that screen are persisted: The above involved invalidating the cache as soon as the item is updated. |
ardalis
reviewed
Dec 3, 2019
src/Web/Pages/Admin/Index.cshtml.cs
Outdated
| var itemsPerPage = Constants.ITEMS_PER_PAGE; | ||
| var brandFilterApplied = catalogModel.BrandFilterApplied; | ||
| var typesFilterApplied = catalogModel.TypesFilterApplied; | ||
| var cacheKey = string.Format(_itemsKeyTemplate, pageIndex, itemsPerPage, brandFilterApplied, typesFilterApplied); |
There was a problem hiding this comment.
Is there somewhere we can share this so the key used when reading matches the same code as the key used here when updating?
ardalis
reviewed
Dec 3, 2019
ardalis
approved these changes
Dec 11, 2019
alscoundrel
pushed a commit
to alscoundrel/eShopOnWeb
that referenced
this pull request
Feb 20, 2020
* Updates based on documentation * Getting the build passing * Getting app functioning * A few cleanups to confirm it's working as expected * Fixing functional tests * Updating dockerfile for 3.0 * Functional Tests now run sequentially * Updating to latest version of moq * Adding migration for post 3.0 upgrades * Removing commented out lines * Moving address and catalogitemordered configuration in to classes that own them * Adding admin user * Adding admin catalog screen - will also only display menu option if user is logged in as an admin * WIP - squash this * Allow user to edit a catalog item * Adding entry for new service * Invalidating cache after catalog item update - also a little bit of cleanup * Fixing bad merge * Removing Picture Uri and making Id readonly * Adjusting style in menu dropdown so all options are shown * Creating Cache helpers with unit tests
alscoundrel
pushed a commit
to alscoundrel/eShopOnWeb
that referenced
this pull request
Feb 20, 2020
* Updates based on documentation * Getting the build passing * Getting app functioning * A few cleanups to confirm it's working as expected * Fixing functional tests * Updating dockerfile for 3.0 * Functional Tests now run sequentially * Updating to latest version of moq * Adding migration for post 3.0 upgrades * Removing commented out lines * Moving address and catalogitemordered configuration in to classes that own them * Adding admin user * Adding admin catalog screen - will also only display menu option if user is logged in as an admin * WIP - squash this * Allow user to edit a catalog item * Adding entry for new service * Invalidating cache after catalog item update - also a little bit of cleanup * Fixing bad merge * Removing Picture Uri and making Id readonly * Adjusting style in menu dropdown so all options are shown * Creating Cache helpers with unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.