Use email as displayname for new users that are lacking first and last name #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikskog
force-pushed
the
display-name-problem
branch
from
ffb069b
to
8116c42
Compare
henrikskog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope
emailis getting set on sign up? When you sign up as a new user on OW thorugh auth0 now, first and last name are not gathered, and you can't even set it manually in auth0 dashboard afaik.It is much better to show the email for now until the first name and last name are gathered. Right now it is useless to use with new users.
This PR uses email if last_name and first_name are not set.
NB:
""is falsy in javascript, so the check is fine.