Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how we've used domain driven design #840

Conversation

junlarsen
Copy link
Member

Quite a bit of yapping but it should give beginners an idea of why we do it, how it's useful, and how we implement it

Copy link

linear bot commented Mar 12, 2024

@junlarsen junlarsen changed the title Documentat how we've use domain driven design Document how we've use domain driven design Mar 12, 2024
@junlarsen junlarsen changed the title Document how we've use domain driven design Document how we've used domain driven design Mar 12, 2024
@hanlun0804
Copy link
Contributor

I think it was a nice introduction, some yapping is nice when you go from not knowing what it is :)

@henrikskog
Copy link
Contributor

Looking good! I would like a lot more examples, but this is something we can iterate on going forward

@henrikskog
Copy link
Contributor

henrikskog commented Mar 16, 2024

It would be nice to include some examples of the patterns we follow in repositories and services. For example, when a delete method in a repository returns null, it means that there was no such resource to delete. This sort of stuff is important to document I think, as we are making these rules ourselves.

(delete example may not be entirely correct, but I hope I get my point across)

@junlarsen
Copy link
Member Author

I agree we should add stuff about "return null" and other paradigms we've used, but I think they are probably better fit in another document

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
invoicification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 3:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants