-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Bug Report
| Q | A |
|---|---|
| Version(s) | 1.0.1 |
Summary
When generating InputFilters in a Dotkernel Admin project, the constructor method is set to return self.
Current behavior
class CreateMagazineInputFilter extends AbstractInputFilter
{
public function __construct()
{
// chain inputs below
return $this
->add(new CsrfInput('CreateMagazineCsrf', true));
}
}Expected behavior
This might be a minor issue within the "headless platform" projects themselves, as API and Admin both use
inputFilters in slightly different ways (construct in API, init in Admin)
As for dot-maker:
- replacing the constructor method with an
init()method and keeping thereturn, to match the existing codebase, - dropping the
returnfrom the__construct, to match the InputFilter structure inDotkernel API, but that would mean updating the Admin codebase.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working