Skip to content

Issue #110: update book tutorial #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 22, 2025
Merged

Conversation

Howriq
Copy link
Member

@Howriq Howriq commented May 12, 2025

No description provided.

@Howriq Howriq requested a review from alexmerlin May 12, 2025 20:55
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be continued...

Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In ReleaseDateInput, replace:
    'message' => sprintf(Message::INVALID_VALUE, 'releaseDate'),
    with:
    'message' => Message::INVALID_VALUE,
    and remove use function sprintf;.

  2. The migrations diff command is outdated, replace it with:

php ./vendor/bin/doctrine-migrations diff
  1. The path mentioned in this sentence has changed in 6.0:

This will check for differences between your entities and database structure and create migration files if necessary, in data/doctrine/migrations.

Version 6.0 stores migrations in the Core module under the following path:
src/Core/src/App/src/Migration

  1. The migrations run command should also be updated:
php ./vendor/bin/doctrine-migrations migrate
  1. Rename across the document GetBookHandler to GetBookResourceHandler

  2. Rename across the document PostBookHandler to PostBookResourceHandler

so that they follow our naming convention.

@Howriq Howriq requested a review from alexmerlin May 14, 2025 10:28
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, these steps will have to be tested in version 6.0 of Dotkernel API.

@Howriq Howriq requested a review from alexmerlin May 19, 2025 09:11
Signed-off-by: horea <horea@rospace.com>
Signed-off-by: horea <horea@rospace.com>
@Howriq Howriq requested a review from alexmerlin May 20, 2025 17:43
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Format the contents of Book->getArrayCopy
  2. Replace the To retrieve a book use: section with:

To retrieve a book, curl one of the links found in the output of the list books command, under _embedded . books . * . _links . self . href

Howriq added 2 commits May 21, 2025 11:30
Signed-off-by: horea <horea@rospace.com>
Signed-off-by: horea <horea@rospace.com>
@Howriq Howriq requested a review from alexmerlin May 21, 2025 09:03
Howriq and others added 2 commits May 21, 2025 13:03
Signed-off-by: horea <horea@rospace.com>
Signed-off-by: Howriq <63609103+Howriq@users.noreply.github.com>
Signed-off-by: Alex Karajos <alex.merlin.1985@gmail.com>
Signed-off-by: Alex Karajos <alex.merlin.1985@gmail.com>
Signed-off-by: Alex Karajos <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin merged commit 7e0f193 into dotkernel:main May 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update book tutorial
2 participants