Skip to content

Changed annotations into attributes - #194

Merged
arhimede merged 2 commits into
4.0from
issue-193
Oct 31, 2023
Merged

Changed annotations into attributes#194
arhimede merged 2 commits into
4.0from
issue-193

Conversation

@marioradu05

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 30, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f80389d) 71.05% compared to head (98a0300) 71.05%.
Report is 1 commits behind head on 4.0.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.0     #194   +/-   ##
=========================================
  Coverage     71.05%   71.05%           
  Complexity      328      328           
=========================================
  Files            39       39           
  Lines          1534     1534           
=========================================
  Hits           1090     1090           
  Misses          444      444           
Files Coverage Δ
src/Admin/src/ConfigProvider.php 100.00% <100.00%> (ø)
src/Admin/src/Entity/Admin.php 100.00% <ø> (ø)
src/Admin/src/Entity/AdminLogin.php 100.00% <ø> (ø)
src/Admin/src/Entity/AdminRole.php 100.00% <ø> (ø)
src/App/src/Common/TimestampAwareTrait.php 88.23% <100.00%> (ø)
src/App/src/Common/UuidAwareTrait.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/Admin/src/Entity/AdminLogin.php Outdated
Comment thread src/Admin/src/Entity/Admin.php Outdated
Comment thread src/Admin/src/Entity/AdminLogin.php Outdated
Comment thread src/Admin/src/Entity/AdminRole.php Outdated
@alexmerlin alexmerlin linked an issue Oct 31, 2023 that may be closed by this pull request
@arhimede
arhimede merged commit 898439a into 4.0 Oct 31, 2023
@arhimede
arhimede deleted the issue-193 branch October 31, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace annotation with attribute

3 participants