Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dotenvx CLI integration by adding two new optional arguments, dotenv_path and override, to allow for more flexible execution of the binary. Key changes include:
- Adding dotenv_path and override parameters to load_dotenvx and dotenvx_get.
- Updating the command arguments based on the provided parameters.
- Updating the changelog to reflect the new version and feature additions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dotenvx/main.py | Introduced dotenv_path and override parameters; updated function return type |
| CHANGELOG.md | Updated version number and changelog entry for the new feature |
Comments suppressed due to low confidence (1)
src/dotenvx/main.py:24
- Changing load_dotenvx to return a boolean instead of the parsed JSON can break existing API contracts if clients expect the full parsed object. Consider updating the documentation or reverting the return value change to ensure consistency.
return True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.