Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation annotations #54

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Remove deprecation annotations #54

merged 1 commit into from
Jun 25, 2020

Conversation

Plecra
Copy link
Contributor

@Plecra Plecra commented Jun 25, 2020

Addresses #13

Was there some blocker for this? I can make more changes if that's necessary

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #54 into master will decrease coverage by 14.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
- Coverage   77.29%   62.66%   -14.64%     
===========================================
  Files          18       18               
  Lines         740      908      +168     
===========================================
- Hits          572      569        -3     
- Misses        168      339      +171     
Impacted Files Coverage Δ
dotenv/src/lib.rs 100.00% <ø> (ø)
dotenv/tests/test-dotenv-iter.rs 100.00% <ø> (ø)
dotenv/tests/test-from-filename-iter.rs 100.00% <ø> (ø)
dotenv/tests/test-from-path-iter.rs 100.00% <ø> (ø)
dotenv/src/parse.rs 50.63% <0.00%> (-19.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15856...c89ed77. Read the comment docs.

@ZoeyR ZoeyR merged commit fcdfc49 into dotenv-rs:master Jun 25, 2020
@ZoeyR
Copy link
Contributor

ZoeyR commented Jun 25, 2020

Thanks! I forgot to remove these a while ago

@alex35mil
Copy link

@ZoeyR Can you, please, release this change?

@kevlarr
Copy link

kevlarr commented Dec 2, 2021

Has this been published? Latest on crates.io is 0.15.0 and iter functions are still deprecated.

codemountains pushed a commit to codemountains/dotenvx that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants