Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Analytics #1079

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Use Google Analytics #1079

merged 1 commit into from
Apr 12, 2022

Conversation

kamilkisiela
Copy link
Collaborator

@kamilkisiela kamilkisiela commented Apr 12, 2022

Why not a component? Next.js + CJS goes crazy when I use next/router.js and next/script.js.
I get: https://reactjs.org/docs/error-decoder.html/?invariant=130&args%5B%5D=object&args%5B%5D=
Probably because of two different versions of React or something. Not sure...

I could do a component here, just for Yoga website but keeping it the same as in @guild-docs/client makes it easier to transition later.

Other Guild websites imports useGoogleAnalytics hook from @guild-docs/client but it does not currently work with React 18 (Yoga uses 18).

@kamilkisiela kamilkisiela merged commit ad17808 into master Apr 12, 2022
@kamilkisiela kamilkisiela deleted the kamil-analytics branch April 12, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant