Excluded the __typename from the root node of subscriptions when using addTypenameSelectionDocumentTransform with documentTransforms #9889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
__typename
should not be added to the root node of a subscription when usingaddTypenameSelectionDocumentTransform
withdocumentTransforms
since a single root node is expected and the code generator fails because of that (refer to the specification).Related # (issue)
#9888
Type of change
Sandbox:
Issue Sandbox
How Has This Been Tested?
The fix is also included in the issue sandbox. The code can be run in 3 setups for testing:
yarn generate
which doesn't use the document transformer and works fineyarn generate --add-typenames
which uses the current faulty document transformer and failsyarn generate --add-fixed-typenames
which uses my fixed version of the document transformer and works fineTest Environment:
@graphql-codegen/client-preset
: 4.2.4Checklist: