Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nested fragments in string document mode #9414

Merged
merged 7 commits into from
May 19, 2023

Conversation

beerose
Copy link
Contributor

@beerose beerose commented May 15, 2023

Related #9356

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: ac91dbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/client-preset Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/graphql-modules-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beerose beerose requested review from n1ru4l and saihaj May 15, 2023 19:27
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 3.3.2-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/introspection 3.0.2-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 4.0.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 3.0.5-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 3.0.2-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.0.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.0.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 4.1.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.0.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 3.1.0-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 3.1.4-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/testing 2.0.3-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎
@graphql-codegen/plugin-helpers 4.2.1-alpha-20230519115842-ac91dbb2f npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

💻 Website Preview

The latest changes are available as preview in: https://331d597c.graphql-code-generator.pages.dev

Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
@beerose beerose merged commit ca02ad1 into master May 19, 2023
@beerose beerose deleted the nested-fragments-string-mode branch May 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants