Skip to content

Conversation

@ohsory1324
Copy link
Contributor

Description

When I run yarn graphql-codegen init, it just print some options and is ended immediately. So I add await operator to prevent it from early returning.

Related #8162

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

yarn graphql-codegen init

스크린샷 2022-07-31 오전 12 18 15

How Has This Been Tested?

I haven't tested this. But if it is needed tell me how I can test.

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2022

🦋 Changeset detected

Latest commit: 5843c5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 30, 2022

@ohsory1324 is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@saihaj
Copy link
Collaborator

saihaj commented Jul 30, 2022

Hey @ohsory1324 thanks for this! can you run yarn changeset and add a patch explaining your fix.

@saihaj
Copy link
Collaborator

saihaj commented Jul 30, 2022

Thanks!

@ohsory1324 ohsory1324 force-pushed the fix/early-returning-when-init-on-cli branch from b454bda to 42c2ad2 Compare July 30, 2022 15:45
@saihaj
Copy link
Collaborator

saihaj commented Jul 30, 2022

Oops looks like you forced push and the changeset is gone again 😂

@ohsory1324
Copy link
Contributor Author

Oops looks like you forced push and the changeset is gone again 😂

Sorry about confusing PR 😂

@saihaj
Copy link
Collaborator

saihaj commented Jul 30, 2022

Oops looks like you forced push and the changeset is gone again 😂

Sorry about confusing PR 😂

All good m. Will wait for CI and cut a release. Thanks!

@saihaj saihaj merged commit b75ca4b into dotansimha:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants