-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: fix rawRequest return type #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix rawRequest return type #7676
Conversation
🦋 Changeset detectedLatest commit: 5437075 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/6oEqubPMBfQ3JGss8N1peYLw4y1T |
Released in |
@P4sca1 @charlypoly Hi, I tried v4.4.4 and I got the following error:
This PR removed the references to GraphQLError from generated code. |
Thanks for pointing this out! |
@charlypoly thanks 👍 |
Fixed in |
Description
The errors property from the return type has been removed, because it is never
returned by
graphql-request
. Instead, failed requests throw aClientError
.Also, data is no longer optional, because it always exists for successful responses.
Related #7592
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing snapshots have been updated.