[typescript-operations] Fix external custom scalars not getting imported #10584
+1,107
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto shared type file
5 tasks
🦋 Changeset detectedLatest commit: 3a44df6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
commented
Jan 25, 2026
Comment on lines
+423
to
+435
| public getEnumsImports(): string[] { | ||
| const usedEnumMap: ParsedEnumValuesMap = {}; | ||
| for (const [enumName, enumDetails] of Object.entries(this.config.enumValues)) { | ||
| if (this._usedNamedInputTypes[enumName]) { | ||
| usedEnumMap[enumName] = enumDetails; | ||
| } | ||
| } | ||
|
|
||
| return getEnumsImports({ | ||
| enumValues: usedEnumMap, | ||
| useTypeImports: this.config.useTypeImports, | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I moved this up here as a drive-by to keep similar imports methods closer together.
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
6.1.2-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
5.0.1-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
7.0.0-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
5.0.8-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
5.1.3-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
6.0.0-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
6.0.0-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
6.1.6-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
6.0.0-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
6.0.0-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
5.1.3-alpha-20260125135505-3a44df6ccbf1d89c6f8128d64583d534868311e1 |
npm ↗︎ unpkg ↗︎ |
eddeee888
commented
Jan 25, 2026
Comment on lines
+576
to
+578
| if (usedInputTypes[node.name]) { | ||
| return; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
GraphQLInputObjectType and GraphQLEnumType don't have special cases like GraphQLScalarType where it may need special handling depending on where it's used (tracked by useCases). Therefore, we can return early for the former two if we've seen them previously
eddeee888
commented
Jan 25, 2026
Collaborator
Author
There was a problem hiding this comment.
This is renamed to ts-douments.standalone.scalars.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix an issue where external custom scalars are not imported correctly into files:
Related #10496
Type of change
How Has This Been Tested?