Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolvers][federation] Fix mapper being incorrectly used as the base type for reference #10216

Open
wants to merge 8 commits into
base: federation-fixes
Choose a base branch
from
+317 −139
Open

[resolvers][federation] Fix mapper being incorrectly used as the base type for reference #10216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
661e039
Fix reference being assigned mappers incorrectly
eddeee888 Dec 10, 2024
64ab400
Add test for federation mappers usage in reference
eddeee888 Dec 10, 2024
9273310
Add changeset
eddeee888 Dec 10, 2024
c932044
Remove extraneous UnwrappedObject type
eddeee888 Dec 16, 2024
bab88db
Change to major because it may break existing use cases
eddeee888 Dec 16, 2024
c3a9410
Run CI on federation-fixes feature branch
eddeee888 Dec 16, 2024
9d1df52
Update dev tests
eddeee888 Dec 16, 2024
a784d3b
Clean up tests
eddeee888 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up tests
  • Loading branch information
@eddeee888
eddeee888 committed Dec 22, 2024
commit a784d3bf06225f47066ff6e99a270fabb201f32f
16 changes: 1 addition & 15 deletions packages/plugins/typescript/resolvers/tests/ts-resolvers.federation.mappers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,5 @@
import '@graphql-codegen/testing';
import { codegen } from '@graphql-codegen/core';
import { parse } from 'graphql';
import { TypeScriptResolversPluginConfig } from '../src/config.js';
import { plugin } from '../src/index.js';

function generate({ schema, config }: { schema: string; config: TypeScriptResolversPluginConfig }) {
return codegen({
filename: 'graphql.ts',
schema: parse(schema),
documents: [],
plugins: [{ 'typescript-resolvers': {} }],
config,
pluginMap: { 'typescript-resolvers': { plugin } },
});
}
import { generate } from './utils';

describe('TypeScript Resolvers Plugin + Apollo Federation - mappers', () => {
it('generates FederationTypes and use it for reference type', async () => {
Expand Down
15 changes: 15 additions & 0 deletions packages/plugins/typescript/resolvers/tests/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { codegen } from '@graphql-codegen/core';
import { parse } from 'graphql';
import { TypeScriptResolversPluginConfig } from '../src/config.js';
import { plugin } from '../src/index.js';

export function generate({ schema, config }: { schema: string; config: TypeScriptResolversPluginConfig }) {
return codegen({
filename: 'graphql.ts',
schema: parse(schema),
documents: [],
plugins: [{ 'typescript-resolvers': {} }],
config,
pluginMap: { 'typescript-resolvers': { plugin } },
});
}
Loading