Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow function as valid type for UrlSchemaOptions.customFetch #10150

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ArminWiebigke
Copy link

@ArminWiebigke ArminWiebigke commented Sep 24, 2024

Description

This fixes the type definition of UrlSchemaOptions.customFetch, to match the actual values that are allowed to be used: Allow a function to be provided as customFetch.

See #9667

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Added a new test that uses a function as value for customFetch, although the actual implementation is in graphql-tools.

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 7982799

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArminWiebigke ArminWiebigke marked this pull request as ready for review October 28, 2024 21:27
@ArminWiebigke
Copy link
Author

Can anyone take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant